Improve get_ownvalue. Narrower type annotations. #1278
Conversation
Co-authored-by: R. Bernstein <rocky@users.noreply.github.com>
mathics/doc/online.py
Outdated
| # mypy complains about the plane conversion, but | ||
| # to_python() returns a string wrapped in quotes. | ||
| # So, let's get ride the quotes... | ||
| usagetext = rulemsg.get_replace_value().to_python(use_quotes=False) |
There was a problem hiding this comment.
Sorry - the option name is string_quotes not use_quotes.
|
LGTM |
|
Forgot to mention this comment independent of the spelling mistake is wrong and should be removed. We have a type error, mypy catches it, and we have to adjust the code. This can get addressed in a future PR though. |
Yes, I am working on a few changes more on Definitions. I can remove it in the next PR. |
Could we get the brokenness fixed on mathicsscript and mathics-django fixed first, please? |
|
Sure. Definitions.get_ownvalue now returns a BaseElement. Mathics3/mathicsscript#88 fixes mathicsscript. Mathics-Django seems to be automatically fixed. |
Investigating the causes of Mathics3/mathicsscript#87 (comment) I discover that
we were not consistent in the use of
Definitions.get_ownvalue. This PR tries to amend this.